GTest gets scheduled using try auto with artifact builds and always fails
Categories
(Firefox Build System :: Task Configuration, defect, P2)
Tracking
(firefox89 fixed)
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: masterwayz, Assigned: masterwayz, Mentored)
References
Details
Attachments
(1 file)
As I tend to only touch JS, I use the artifacts a lot.
From what I have been told the GTest job only works with binary builds, not with artifact builds.
Whenever I use ./mach try auto
with an artifact build, sometimes the GTest job gets scheduled and always fails.
Example: https://treeherder.mozilla.org/jobs?repo=try&author=michael%40masterwayz.nl&searchStr=GTest
When looking at the failed jobs, it runs from an artifact build. When looking at green jobs, it runs from a full build.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Sidenote: if the fix is easy then I'm more than willing to help out. However I'm not sure how the try auto stuff works so I would need some pointers and guidance, but I do want to mention it.
Comment 3•4 years ago
|
||
Thanks for filing, good issue!
This isn't a super easy fix, but it's also not terribly difficult and I'd be willing to help walk you through it if you're interested. I think there are two parts to this bug:
- Invent a configuration key in our tasks to denote tasks that don't support artifact builds. E.g, we could add:
supports-artifact-builds: false
to the task config. Note you'll need to update the schema in taskcluster/taskgraph/transforms/tests.py
to support this.
- Create a "target task filter" in target_tasks.py that filters out any task that contains this key whenever artifact builds are detected. Then make sure this filter gets run for
mach try auto
pushes (and possibly all try pushes).
Then there's a third bonus part which could be a follow-up bug:
- Also detect tasks that have this key when running
mach try fuzzy
locally and print out an error message if someone tries to schedule one with artifact builds enabled.
Anyway, let me know if you'd like to have a go at this and I can provide more context if necessary.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Updated•4 years ago
|
Comment 6•4 years ago
|
||
bugherder |
Description
•