Closed Bug 1695325 Opened 4 years ago Closed 4 years ago

GTest gets scheduled using try auto with artifact builds and always fails

Categories

(Firefox Build System :: Task Configuration, defect, P2)

defect

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: masterwayz, Assigned: masterwayz, Mentored)

References

Details

Attachments

(1 file)

As I tend to only touch JS, I use the artifacts a lot.

From what I have been told the GTest job only works with binary builds, not with artifact builds.
Whenever I use ./mach try auto with an artifact build, sometimes the GTest job gets scheduled and always fails.

Example: https://treeherder.mozilla.org/jobs?repo=try&author=michael%40masterwayz.nl&searchStr=GTest

When looking at the failed jobs, it runs from an artifact build. When looking at green jobs, it runs from a full build.

Summary: GTest gets scheduled using try auto with artifact builds → GTest gets scheduled using try auto with artifact builds and always fails

ahal, is this something you'd handle?

Flags: needinfo?(ahal)

Sidenote: if the fix is easy then I'm more than willing to help out. However I'm not sure how the try auto stuff works so I would need some pointers and guidance, but I do want to mention it.

Thanks for filing, good issue!

This isn't a super easy fix, but it's also not terribly difficult and I'd be willing to help walk you through it if you're interested. I think there are two parts to this bug:

  1. Invent a configuration key in our tasks to denote tasks that don't support artifact builds. E.g, we could add:
supports-artifact-builds: false

to the task config. Note you'll need to update the schema in taskcluster/taskgraph/transforms/tests.py to support this.

  1. Create a "target task filter" in target_tasks.py that filters out any task that contains this key whenever artifact builds are detected. Then make sure this filter gets run for mach try auto pushes (and possibly all try pushes).

Then there's a third bonus part which could be a follow-up bug:

  1. Also detect tasks that have this key when running mach try fuzzy locally and print out an error message if someone tries to schedule one with artifact builds enabled.

Anyway, let me know if you'd like to have a go at this and I can provide more context if necessary.

Flags: needinfo?(ahal)
Mentor: ahal
Priority: -- → P2
Assignee: nobody → michelle
Attachment #9214427 - Attachment description: WIP: Bug 1695325 - Make sure GTest does not get scheduled on artifact builds r=ahal → Bug 1695325 - Make sure GTest does not get scheduled on artifact builds r=ahal
Status: NEW → ASSIGNED
See Also: → 1703902
Pushed by michelle@masterwayz.nl: https://hg.mozilla.org/integration/autoland/rev/b2920fc5bb11 Make sure GTest does not get scheduled on artifact builds r=ahal
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Blocks: 1704646
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: